Re: [Qemu-devel] [PATCH] migration: Fix migration state update issue

[Dr. David Alan Gilbert]

* Liang Li (address@hidden) wrote:
> If live migration is very fast and can be completed in 1 second,
> the dirty_sync_count of MigrationState will not be updated.
> Then you will see "dirty sync count: 0" in qemu monitor even if
> the actual dirty sync count is not 0.
> 
> Signed-off-by: Liang Li <address@hidden>
> ---
>  arch_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch_init.c b/arch_init.c
> index 4c8fcee..a48f575 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -599,8 +599,8 @@ static void migration_bitmap_sync(void)
>          s->dirty_bytes_rate = s->dirty_pages_rate * TARGET_PAGE_SIZE;
>          start_time = end_time;
>          num_dirty_pages_period = 0;
> -        s->dirty_sync_count = bitmap_sync_count;
>      }
> +    s->dirty_sync_count = bitmap_sync_count;
>  }

Yes, makes sense.
(An interesting question is why there needs to be a separate bitmap_sync_count
variable that's separate from s->dirty_sync_count)

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

Dave

>  
>  /**
> -- 
> 1.9.1
> 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK