Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv / object_new_proplist constructors

[Paolo Bonzini]

On 30/04/2015 16:42, Daniel P. Berrange wrote:
> +    propname = va_arg(vargs, char *);
> +    while (propname != NULL) {
> +        const char *value = va_arg(vargs, char *);
> +
> +        g_assert(value != NULL);
> +        object_property_parse(obj, value, propname, errp);
> +        if (*errp) {
> +            goto error;
> +        }
> +        propname = va_arg(vargs, char *);
> +    }
> +
> +    object_property_add_child(container_get(object_get_root(), path),
> +                              id, obj, errp);
> +    if (*errp) {
> +        goto error;
> +    }
> +
> +    if (object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> +        user_creatable_complete(obj, errp);
> +        if (*errp) {
> +            object_property_del(container_get(object_get_root(), path),
> +                                id, &error_abort);

Easier:

    object_unparent(obj);

> +            goto error;
> +        }
> +    }
> +
> +    return obj;

And another one: do we want to unref the object here, since we've added
a stable reference via object_property_add_child?

Do you prefer me too apply patches 1-2-3-5-6-7, minus the testcases, or
do you simply want to resubmit?

Paolo