[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] bios-tables-test: handle false-positive smbi
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] bios-tables-test: handle false-positive smbios signature matches |
|
Date: |
Tue, 28 Apr 2015 14:11:22 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/28/2015 01:55 PM, Gabriel L. Somlo wrote:
> It has been reported that sometimes the .rodata section of SeaBIOS,
> containing the constant string against which the SMBIOS signature
> ends up being compared, also falls withing the guest f-segment. In
s/withing/within/
> that case, the test obviously fails, unless we continue searching
> for the *real* smbios entry point.
>
> Rather than stopping at the first match for the SMBIOS signature
> ("_SM_") in the f-segment (0xF0000-0xFFFFF), continue scanning
> until either a valid entry point table is found, or the f-segment
> has been exhausted.
>
> Reported-by: Bruce Rogers <address@hidden>
> Signed-off-by: Gabriel Somlo <address@hidden>
> Tested-by: Bruce Rogers <address@hidden>
> ---
> tests/bios-tables-test.c | 76
> ++++++++++++++++++++++++++++--------------------
> 1 file changed, 44 insertions(+), 32 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature