[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEA
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi |
Date: |
Tue, 28 Apr 2015 15:28:51 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/4/28 15:15, Michael S. Tsirkin wrote:
> On Tue, Apr 28, 2015 at 02:30:17PM +0800, Shannon Zhao wrote:
>> On 2015/4/28 13:55, Michael S. Tsirkin wrote:
>>> Pong.
>>> You responded to Cornelia's comments on patch 1/2
>>> with "ok will add".
>>> I expected v4.
>>>
>>
>> Yeah, but few comments on this patch, so I just want to confirm this
>> modification is acceptable to virtio-scsi, then will modify the commit
>> log and send v4.
>
> My question would be, why just net and scsi?
> Does not the same apply to all devices?
>
The virtio-blk has been changed before, while leaving net and scsi.
And the other devices don't set host features in the wrappers.
>>> On Tue, Apr 28, 2015 at 08:32:21AM +0800, Shannon Zhao wrote:
>>>> Ping?
>>>>
>>>> On 2015/4/21 18:51, address@hidden wrote:
>>>>> From: Shannon Zhao <address@hidden>
>>>>>
>>>>> Move DEFINE_VIRTIO_SCSI_FEATURES to the backend virtio-scsi.
>>>>> The transports just sync the host features from backend.
>>>>>
>>>>> Signed-off-by: Shannon Zhao <address@hidden>
>>>>> Signed-off-by: Shannon Zhao <address@hidden>
>>>>> ---
>>>>> hw/s390x/s390-virtio-bus.c | 1 -
>>>>> hw/s390x/virtio-ccw.c | 1 -
>>>>> hw/scsi/virtio-scsi.c | 5 +++++
>>>>> hw/virtio/virtio-pci.c | 1 -
>>>>> include/hw/virtio/virtio-scsi.h | 1 +
>>>>> 5 files changed, 6 insertions(+), 3 deletions(-)
>>>>
>>>> --
>>>> Shannon
>>>
>>> .
>>>
>>
>
> .
>
--
Thanks,
Shannon
- [Qemu-devel] [PATCH v3 0/2] virtio: Move host features to backends, shannon . zhao, 2015/04/21
- [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net, shannon . zhao, 2015/04/21
- [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, shannon . zhao, 2015/04/21
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Shannon Zhao, 2015/04/27
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Shannon Zhao, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi,
Shannon Zhao <=
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Michael S. Tsirkin, 2015/04/28
- Re: [Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi, Peter Maydell, 2015/04/28