Re: [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device.

[Michael S. Tsirkin]

On Mon, Apr 27, 2015 at 09:01:36AM -0600, Eric Blake wrote:
> On 04/27/2015 05:19 AM, Gal Hammer wrote:
> > Signed-off-by: Gal Hammer <address@hidden>
> 
> Subject line: Most commits do NOT end in a trailing '.'. It's less
> obvious if there is a preference for starting commits with a capital
> after the subject, but that seems to be the current prevailing trend.

I personally prefer all-lower-case subjects.
In particular upper case after : is just weird.

> So I might have done:
> 
> tests: Add a unit test for vmgenid device
> 
> or even:
> 
> vmgenid: Add a unit test
> 
> (the latter approach would mean grouping all of the series under a
> single topic of vmgenid, instead of your approach of a different topic
> per patch according to which part was being modified in support of
> adding vmgenid. Either approach is fine by me)
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>