[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt boar
From: |
Christoffer Dall |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt board |
Date: |
Mon, 27 Apr 2015 18:06:04 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 21, 2015 at 03:47:13PM +0100, Peter Maydell wrote:
[...]
> > @@ -340,9 +357,31 @@ static void fdt_add_gic_node(VirtBoardInfo *vbi)
> > 2, vbi->memmap[VIRT_GIC_DIST].size,
> > 2, vbi->memmap[VIRT_GIC_CPU].base,
> > 2, vbi->memmap[VIRT_GIC_CPU].size);
> > + qemu_fdt_setprop_cell(vbi->fdt, "/intc", "#address-cells", 0x2);
> > + qemu_fdt_setprop_cell(vbi->fdt, "/intc", "#size-cells", 0x2);
> > + qemu_fdt_setprop(vbi->fdt, "/intc", "ranges", NULL, 0);
> >
>
> Why do we need an empty ranges attribute?
>
Without it, Linux fails to make things work. I suspect this is related
to specifically setting the #address-cells and #size-cells.
I forgot by now, but I think when I originally wrote this patch I traced
through the Linux code and found out that it was required somewhere.
I also think the AMD GICv2m FDT has the empty ranges property.
-Christoffer
Re: [Qemu-devel] [PATCH 2/3] arm_gicv2m: Add GICv2m widget to support MSIs, Peter Maydell, 2015/04/21
[Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt board, Christoffer Dall, 2015/04/08
Re: [Qemu-devel] [PATCH 0/3] Add support for for GICv2m and MSIs to arm-virt, Peter Maydell, 2015/04/08
Re: [Qemu-devel] [PATCH 0/3] Add support for for GICv2m and MSIs to arm-virt, Nikolay Nikolaev, 2015/04/08