[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition |
Date: |
Mon, 27 Apr 2015 17:40:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 27/04/2015 00:04, Emilio G. Cota wrote:
> It's defined in osdep.h and shouldn't be redefined here.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> tests/i440fx-test.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index d0bc8de..33a7ecb 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -27,8 +27,6 @@
>
> #define BROKEN 1
>
> -#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
> -
> typedef struct TestData
> {
> int num_cpus;
>
Looks good; I am CCing address@hidden so that Michael will
notice this patch.
Reviewed-by: Paolo Bonzini <address@hidden>
Paolo