[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 01/36] qapi: Add copyright declaration on doc
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 01/36] qapi: Add copyright declaration on docs |
Date: |
Mon, 27 Apr 2015 16:42:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> While our top-level COPYING with its GPLv2+ license applies to
> any documentation file that omits explicit instructions, these
> days it's better to be a good example of calling out our
> intentions. Correct use of GPL requires the use of a copyright
> statement, so I'm adding notice to two QAPI documents, by
> attributing these files to the initial authors and major
> contributors. I used:
>
> $ git blame --line-porcelain $file \
> | sed -n 's/^author //p' | sort | uniq -c | sort -rn
>
> to determine authorship of these two files. qmp-spec.txt blames
> entirely to Red Hat (easy, since my contribution falls in that
> category); while qapi-code-gen.txt has multiple contributors
> representing multiple entities. But since it was originally
> supplied by Michael Roth, the notice I added there copies the
> notice he has used in other files. As there is no intended
> change in license from the implicit one previously present from
> the top level, I have not bothered to CC other contributors;
> if we want to weaken things to something looser (such as LGPL)
> so that there is no question that someone re-implementing the
> spec is not forced to use GPL, that would be a different commit.
>
> CC: Michael Roth <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
>
> v6: split off from v5:1/28, add Copyright lines
> ---
> docs/qapi-code-gen.txt | 8 ++++++++
> docs/qmp/qmp-spec.txt | 10 ++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt
> index 8313ba6..e8bbaf8 100644
> --- a/docs/qapi-code-gen.txt
> +++ b/docs/qapi-code-gen.txt
> @@ -1,5 +1,13 @@
> = How to use the QAPI code generator =
>
> +Copyright IBM Corp. 2011
> +Copyright (C) 2012-2015 Red Hat, Inc.
> +
> +This work is licensed under the terms of the GNU GPL, version 2 or
> +later. See the COPYING file in the top-level directory.
> +
> +== Introduction ==
> +
> QAPI is a native C API within QEMU which provides management-level
> functionality to internal/external users. For external
> users/processes, this interface is made available by a JSON-based
> diff --git a/docs/qmp/qmp-spec.txt b/docs/qmp/qmp-spec.txt
> index 22568c6..3e503e6 100644
> --- a/docs/qmp/qmp-spec.txt
> +++ b/docs/qmp/qmp-spec.txt
> @@ -1,5 +1,15 @@
> QEMU Machine Protocol Specification
>
> +0. About This Document
> +======================
> +
> +Copyright (C) 2009-2015 Red Hat, Inc.
> +
> +This work is licensed under the terms of the GNU GPL, version 2 or
> +later. See the COPYING file in the top-level directory.
> +
> +Last revised in March 2015.
s/March/April/
I recomment not to add this line. It goes stale easily, and git is much
more reliable source of revision information anyway. Matter of taste,
so...
> +
> 1. Introduction
> ===============
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 01/36] qapi: Add copyright declaration on docs, Eric Blake, 2015/04/05
- Re: [Qemu-devel] [PATCH v6 01/36] qapi: Add copyright declaration on docs,
Markus Armbruster <=
- [Qemu-devel] [PATCH v6 04/36] qapi: Fix generation of 'size' builtin type, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 03/36] qapi: Simplify builtin type handling, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 05/36] qapi: Require ASCII in schema, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 12/36] qapi: Prepare for catching more semantic parse errors, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 07/36] qapi: Better error messages for bad enums, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 09/36] qapi: Clean up test coverage of simple unions, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 06/36] qapi: Add some enum tests, Eric Blake, 2015/04/05
- [Qemu-devel] [PATCH v6 10/36] qapi: Forbid base without discriminator in unions, Eric Blake, 2015/04/05