[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu |
Date: |
Thu, 23 Apr 2015 17:11:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/23/2015 04:57 PM, address@hidden wrote:
> The major changes from last time are:
That says this series should probably be named v2 (git
format-patch/send-email -v2) or later, as part of the subject line. If
the previous version is more than a couple weeks ago, it's also nice
(but not required) to provide a URL to the archives of the previous
discussion.
>
> * Don't use callbacks for adding firmware tables, provide binary
> blobs instead.
>
> * Add the SSDT as a separate table.
>
> * Modify the BIOS tests to test for the IPMI tables.
>
Also, you might want to use git format-patch --cover-letter, which helps
form a 00/17 letter with a diffstat pre-filled; the diffstat gives
reviewers a quick glance at what files are touched, and how many lines
of code are being impacted, which makes it easier to decide when to
schedule a review for the series.
More patch submission hints at: http://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 09/17] ipmi: Add migration capability to the IPMI device., (continued)
- [Qemu-devel] [PATCH 09/17] ipmi: Add migration capability to the IPMI device., minyard, 2015/04/23
- [Qemu-devel] [PATCH 10/17] ipmi: Add a firmware configuration repository, minyard, 2015/04/23
- [Qemu-devel] [PATCH 12/17] smbios: Add a function to directly add an entry, minyard, 2015/04/23
- [Qemu-devel] [PATCH 13/17] pc: Postpone SMBIOS table installation to post machine init, minyard, 2015/04/23
- [Qemu-devel] [PATCH 14/17] ipmi: Add SMBIOS table entry, minyard, 2015/04/23
- [Qemu-devel] [PATCH 15/17] acpi: Add a way for devices to add ACPI tables, minyard, 2015/04/23
- [Qemu-devel] [PATCH 16/17] ipmi: Add ACPI table entries, minyard, 2015/04/23
- [Qemu-devel] [PATCH 17/17] bios: Add tests for the IPMI ACPI and SMBIOS entries, minyard, 2015/04/23
- Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu, Paolo Bonzini, 2015/04/24