Re: [Qemu-devel] [PATCH v1 RFC 06/34] qom: add a object_property_add_enum helper method

[Daniel P. Berrange]

On Fri, Apr 17, 2015 at 05:19:31PM +0200, Paolo Bonzini wrote:
> 
> 
> On 17/04/2015 17:11, Daniel P. Berrange wrote:
> > > On second thought (after seeing patch 7), please add a property type
> > > argument here.  We lose introspection of enum property types otherwise.
> > 
> > Can you give me a pointer to where we lose introspection ? The hostmem
> > code just registers its 'policy' property with a type name of 'str',
> 
> That was already a bug. :(  It should have been registered as 
> "HostMemPolicy".  See for example:

Ok, next time I'll probably send a patch which fixes that bug independantly
and then does the conversion, in case we want the fix on stable too.

> $ qemu-system-x86_64 -device ide-hd,help
> ide-hd.bootindex=int32
> ide-hd.unit=uint32
> ide-hd.bios-chs-trans=BiosAtaTranslation (Logical CHS translation algorithm, 
> auto/none/lba/large/rechs)
> ...
> 
> > which I've just changed to 'enum' in patch 7, so I didn't think I was
> > regressing anything. Is there some QMP command which you think looses
> > the info that I can verify.
> 
> The qom-list command returns a list of property names and types.

Thanks, will look at that.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|