[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine |
|
Date: |
Fri, 17 Apr 2015 11:58:13 +0100 |
On 17 April 2015 at 11:49, Leon Alrae <address@hidden> wrote:
> On 17/04/2015 11:42, Peter Maydell wrote:
>> On 17 April 2015 at 10:46, Leon Alrae <address@hidden> wrote:
>>> After commit 5312bd8 the bonito_readl() and bonito_writel() have been
>>> accessing incorrect addresses. Consequently QEMU is crashing when trying
>>> to boot Linux kernel on fulong2e machine.
>>>
>>> Cc: address@hidden
>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>> Signed-off-by: Leon Alrae <address@hidden>
>>
>> This is Paolo's patch, right? (it has his signoff). It
>> should have him as the author as well, but you seem to have
>> lost that...
>
> Well, I asked Paolo if he wanted to send the patch, but he suggested to
> send the pull request by myself and just put his Signed-off-by line.
It's fine for you to send the patch, but you need to send it with
a From line in the commit message from him, not you.
-- PMM