[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp-commands: fix incorrect uses of ":O" specif
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH] qmp-commands: fix incorrect uses of ":O" specifier |
|
Date: |
Wed, 15 Apr 2015 14:18:35 +0200 |
|
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Wed 15 Apr 2015 01:30:04 PM CEST, Paolo Bonzini wrote:
> As far as the QMP parser is concerned, neither the 'O' nor the 'q'
> format specifiers put any constraint on the command. However, there
> are two differences:
>
> 1) from a documentation point of view 'O' says that this command takes
> a dictionary. The dictionary will be converted to QemuOpts in the
> handler to match the corresponding HMP command.
Is that documentation the comments in monitor.c? It could also be a good
moment to document there 'q' as well.
Otherwise the patch looks good to me,
Reviewed-by: Alberto Garcia <address@hidden>
Berto