Re: [Qemu-devel] [PATCH RFC 05/19] qapi: Simplify c_enum_const()

[Eric Blake]

On 04/02/2015 11:28 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index e1c5ef2..3601d1d 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -906,6 +906,4 @@ def camel_to_upper(value):
>      return new_name.lstrip('_').upper()
>  
>  def c_enum_const(type_name, const_name):
> -    abbrev_string = camel_to_upper(type_name)
> -    value_string = camel_to_upper(const_name)
> -    return "%s_%s" % (abbrev_string, value_string)
> +    return camel_to_upper(type_name + '_' + const_name)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature