Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags

[Andreas Färber]

Am 10.04.2015 um 10:59 schrieb Paolo Bonzini:
> On 10/04/2015 10:53, Andreas Färber wrote:
>>> Ok, that make sense, but if we want to make it platform-neutral, let's
>>> spell it "feature-" or remove the prefix altogether.
>>>
>>> If we remove it, perhaps we could add a QOM property with the list of
>>> features?
>>>
>>> But I don't want to bikeshed too much.
[...]
>> Btw a suffix could work as well and would read more natural. QMP don't
>> sort alphabetically anyway.
> 
> QMP doesn't, but the front-end (scripts/qom-list for example) could.

I don't think our scripts should modify QMP responses. Some commands
transmit things in reverse and we should find out why and fix them
instead of papering over it. In particular for scripts/qom-tree's
sibling nodes (qom-list) I find that very annoying.

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)