[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind
From: |
Ian Campbell |
Subject: |
Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind |
Date: |
Wed, 1 Apr 2015 09:45:42 +0100 |
On Wed, 2015-04-01 at 09:05 +0800, Chen, Tiejun wrote:
> @@ -699,9 +699,35 @@ working graphics passthrough. See the
> XenVGAPassthroughTestedAdapters
> L<http://wiki.xen.org/wiki/XenVGAPassthroughTestedAdapters> wiki page
> for currently supported graphics cards for gfx_passthru.
>
> -gfx_passthru is currently only supported with the qemu-xen-traditional
> -device-model. Upstream qemu-xen device-model currently does not have
> -support for gfx_passthru.
> +gfx_passthru is currently supported both with the qemu-xen-traditional
> +device-model and upstream qemu-xen device-model.
> +
> +When given as a boolean the B<gfx_passthru> option either disables gfx
> +passthru or enables autodetection.
> +
> +But when given as a string the B<gfx_passthru> option describes the type
> +of device to enable. Note this behavior is only supported with the upstream
> +qemu-xen device-model.
Perhaps add "With qemu-xen-traditional IGD is always assumed and other
options than autodetect or explicit IGD will result in an error"?
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index a8b08f2..4fd6310 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -325,7 +325,15 @@ static char **
> libxl__build_device_model_args_old(libxl__gc *gc,
> flexarray_vappend(dm_args, "-net", "none", NULL);
> }
> if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) {
> - flexarray_append(dm_args, "-gfx_passthru");
> + switch (b_info->u.hvm.gfx_passthru_kind) {
> + case LIBXL_GFX_PASSTHRU_KIND_DEFAULT:
> + case LIBXL_GFX_PASSTHRU_KIND_IGD:
> + flexarray_append(dm_args, "-gfx_passthru");
> + break;
> + default:
> + LOG(ERROR, "unsupported gfx_passthru_kind.\n");
Sorry, LOG should not get a \n like my example had, my fault.
With that if you resend the series with git send-email (so it doesn't
get whitespace mangled) I think we are good to go!
Ian.
- Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind,
Ian Campbell <=