[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns
From: |
Ed Maste |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns |
Date: |
Tue, 31 Mar 2015 16:55:53 -0400 |
On 23 March 2015 at 12:56, John Snow <address@hidden> wrote:
> My pattern was cyclical every 256 bytes, so it missed a fairly obvious
> failure case. Add some rand() pepper into the test pattern, and for large
> patterns that exceed 256 sectors, start writing an ID per-sector so that
> we never generate identical sector patterns.
>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Tested-by: Andreas Färber <address@hidden>
> Message-id: address@hidden
> ---
> tests/ahci-test.c | 36 ++++++++++++++++++++++++++++--------
> 1 file changed, 28 insertions(+), 8 deletions(-)
As of the introduction of this test the test suite fails on FreeBSD,
with 6 errors of the form:
ERROR:tests/ahci-test.c:790:ahci_test_io_rw_simple: assertion failed
(memcmp(tx, rx, bufsize) == 0): (0xffffffffffffffff == 0x00000000)
GTester: last random seed: R02S76f68c4cfb2d54af66de227ed44fd54a
I haven't yet done any investigation beyond bisecting.
- [Qemu-devel] [PATCH 0/4] Ide patches for 2.3-rc1, John Snow, 2015/03/23
- [Qemu-devel] [PATCH 1/4] ide: fix cmd_write_pio when nsectors > 1, John Snow, 2015/03/23
- [Qemu-devel] [PATCH 3/4] ahci: Fix sglist offset manipulation for BE machines, John Snow, 2015/03/23
- [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, John Snow, 2015/03/23
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns,
Ed Maste <=
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, John Snow, 2015/03/31
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, Ed Maste, 2015/03/31
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, John Snow, 2015/03/31
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, Ed Maste, 2015/03/31
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, John Snow, 2015/03/31
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, Ed Maste, 2015/03/31
- Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns, John Snow, 2015/03/31
[Qemu-devel] [PATCH 2/4] ide: fix cmd_read_pio when nsectors > 1, John Snow, 2015/03/23
Re: [Qemu-devel] [PATCH 0/4] Ide patches for 2.3-rc1, John Snow, 2015/03/23
Re: [Qemu-devel] [PATCH 0/4] Ide patches for 2.3-rc1, Peter Maydell, 2015/03/23