[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] rcu: do not create thread in pthread_atfork callbac

From: Paolo Bonzini
Subject: [Qemu-devel] [PATCH] rcu: do not create thread in pthread_atfork callback
Date: Tue, 31 Mar 2015 13:01:41 +0200

If QEMU forks after the CPU threads have been created, qemu_mutex_lock_iothread
will not be able to do qemu_cpu_kick_thread.  There is no solution other than
assuming that forks after the CPU threads have been created will end up in an
exec.  Forks before the CPU threads have been created (such as -daemonize)
have to call rcu_after_fork manually.

Notably, the oxygen theme for GTK+ forks and shows a "No such process" error
without this patch.

This patch can be reverted once the iothread loses the "kick the TCG thread"

Reported by: Dr. David Alan Gilbert <address@hidden>

Signed-off-by: Paolo Bonzini <address@hidden>
 include/qemu/rcu.h | 1 +
 os-posix.c         | 2 ++
 util/rcu.c         | 7 +++----
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h
index 506ab58..7df1e86 100644
--- a/include/qemu/rcu.h
+++ b/include/qemu/rcu.h
@@ -117,6 +117,7 @@ extern void synchronize_rcu(void);
 extern void rcu_register_thread(void);
 extern void rcu_unregister_thread(void);
+extern void rcu_after_fork(void);
 struct rcu_head;
 typedef void RCUCBFunc(struct rcu_head *head);
diff --git a/os-posix.c b/os-posix.c
index ba091f1..e4da406 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -39,6 +39,7 @@
 #include "sysemu/sysemu.h"
 #include "net/slirp.h"
 #include "qemu-options.h"
+#include "qemu/rcu.h"
 #include <sys/prctl.h>
@@ -247,6 +248,7 @@ void os_daemonize(void)
         signal(SIGTSTP, SIG_IGN);
         signal(SIGTTOU, SIG_IGN);
         signal(SIGTTIN, SIG_IGN);
+        rcu_after_fork();
diff --git a/util/rcu.c b/util/rcu.c
index 27802a4..7270151 100644
--- a/util/rcu.c
+++ b/util/rcu.c
@@ -311,19 +311,18 @@ static void rcu_init_unlock(void)
-static void rcu_init_child(void)
+void rcu_after_fork(void)
-    qemu_mutex_unlock(&rcu_gp_lock);
     memset(&registry, 0, sizeof(registry));
 static void __attribute__((__constructor__)) rcu_init(void)
-    pthread_atfork(rcu_init_lock, rcu_init_unlock, rcu_init_child);
+    pthread_atfork(rcu_init_lock, rcu_init_unlock, rcu_init_unlock);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]