[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32
Date: Mon, 30 Mar 2015 23:15:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

Hi Kirk,

Am 30.03.2015 um 22:44 schrieb Kirk Allan:
> Ping.
> Looking for feedback anyone might have regarding this patch.

I would recommend to make the patch smaller and the commit message more
intuitive by splitting off the configure changes into its own patch
(remember to include a short cover letter then). It feels strange to
have a new configure option for a single -D though... Can't this value
be overridden via --extra-cflags=-D_WINNT_WINVER=0xf00 already?

CC'ing some people that know about Windows might help, too. Stefan W.
comes to mind.

Also note that we're in Hard Freeze for 2.3 at the moment, which shifts
people's attention to bug fixes.


SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]