[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/2] Add generic can_be_deleted to UserCreata
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/2] Add generic can_be_deleted to UserCreatableClass. |
Date: |
Fri, 27 Mar 2015 15:40:24 +0100 |
On Fri, 27 Mar 2015 13:36:10 +0800
Lin Ma <address@hidden> wrote:
> The patchset adds a generic can_be_deleted callback to UserCreatableClass.
> It prevents removing a usercreatable object if the callback returns false.
>
> Backends could implement the callback if it shoudn't be removed while it's
> in use.
>
> Thank Peter Crosthwaite, Paolo Bonzini, Andreas Färber and Igor Mammedov for
> helping review.
perhaps it's better to take this into 2.3
>
>
> ChangeLog:
> V4:
> Add function user_creatable_can_be_deleted to wrapper can_be_deleted method.
> Remove some unnecessary code.
>
> V3:
> Move the callback to the correct place: UserCreatableClass.
> Move the backend callback implementation to hostmem.c.
>
> V2:
> Make it generic, add the can_be_deleted callback to TypeInfo and TypeImpl.
> Implement the callback in hostmem-file.c and hostmem-ram.c.
>
> V1:
> Initial version, hard coded in object_del to prevent removing an in-use
> host memory backend.
>
>
> Lin Ma (2):
> qom: Add can_be_deleted callback to UserCreatableClass
> hostmem: Prevent removing an in-use memory backend object
>
> backends/hostmem.c | 14 ++++++++++++++
> include/qom/object_interfaces.h | 14 ++++++++++++++
> qmp.c | 5 +++++
> qom/object_interfaces.c | 15 +++++++++++++++
> 4 files changed, 48 insertions(+)
>