[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp versio
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction |
Date: |
Thu, 26 Mar 2015 15:09:19 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Juan Quintela <address@hidden> wrote:
> Eduardo Otubo <address@hidden> wrote:
>> Libseccomp version updated to 2.2.0 and arch restriction to x86/x86_64
>> is now removed. It's supposed to work on armv7l as well.
>>
>> Related bug: https://bugs.launchpad.net/qemu/+bug/1363641
>>
>> Signed-off-by: Eduardo Otubo <address@hidden>
Just in case anyone is interested, default virt-test output with current
qemu
15:05:01 ERROR| Qemu output:
15:05:01 ERROR| qemu-system-x86_64: -sandbox on: sandboxing request but seccomp
is not compiled into this build
15:05:01 ERROR|
15:05:01 ERROR|
15:05:01 ERROR| FAIL type_specific.io-github-autotest-qemu.migrate.default.tcp
-> VMStartError: VM 'virt-tests-vm1' failed to start: Qemu is defunct.
Qemu output:
qemu-system-x86_64: -sandbox on: sandboxing request but seccomp is not compiled
into this build
Notice that you can "fix" the problem running with --qemu_sandbox=off,
but breaking the main test suite just before release looks wrong?
Later, Juan.
>
> This prevent compliation on x86_64 on Fedora 21.
>
> (migration/next)$ make -j5 -C /scratch/tmp/next/all/
> make: Entering directory '/scratch/tmp/next/all'
> config-host.mak is out-of-date, running configure
>
> ERROR: User requested feature libseccomp
> configure was not able to find it.
> Install libseccomp devel >= 2.2.0
>
> Makefile:30: recipe for target 'config-host.mak' failed
> make: *** [config-host.mak] Error 1
> make: Leaving directory '/scratch/tmp/next/all'
> (migration/next)$ rpm -qa | grep seccomp
> libseccomp-2.1.1-5.fc21.x86_64
> libseccomp-devel-2.1.1-5.fc21.x86_64
> libseccomp-debuginfo-2.1.1-5.fc21.x86_64
> (migration/next)$
>
> This was compiling correctly until this patch got in. And virt-test
> uses seccomp by default.
>
> Fedora 21 is less than 3 months old. Do we really want to avoid
> compilation there?
>
> Thanks, Juan.
>
>
>> ---
>> configure | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 589798e..cbe6495 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1848,14 +1848,13 @@ fi
>> # libseccomp check
>>
>> if test "$seccomp" != "no" ; then
>> - if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
>> - $pkg_config --atleast-version=2.1.1 libseccomp; then
>> + if $pkg_config --atleast-version=2.2.0 libseccomp; then
>> libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
>> QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
>> seccomp="yes"
>> else
>> if test "$seccomp" = "yes"; then
>> - feature_not_found "libseccomp" "Install libseccomp devel >=
>> 2.1.1"
>> + feature_not_found "libseccomp" "Install libseccomp devel >=
>> 2.2.0"
>> fi
>> seccomp="no"
>> fi
- [Qemu-devel] [PULL for v2.3 00/01] seccomp branch queue, Eduardo Otubo, 2015/03/25
- [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Eduardo Otubo, 2015/03/25
- Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Juan Quintela, 2015/03/26
- Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Eduardo Otubo, 2015/03/26
- Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Peter Maydell, 2015/03/26
- Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Juan Quintela, 2015/03/26
- Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Eduardo Otubo, 2015/03/26
- Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Juan Quintela, 2015/03/26
- Re: [Qemu-devel] [PULL for v2.3 01/01] seccomp: update libseccomp version and remove arch restriction, Peter Maydell, 2015/03/26
Re: [Qemu-devel] [PULL for v2.3 00/01] seccomp branch queue, Peter Maydell, 2015/03/26