[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement block d
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication |
Date: |
Thu, 26 Mar 2015 15:21:46 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 03/25 17:36, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> block/nbd.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
>
> diff --git a/block/nbd.c b/block/nbd.c
> index 3faf865..753b322 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -458,6 +458,52 @@ static void nbd_refresh_filename(BlockDriverState *bs)
> bs->full_open_options = opts;
> }
>
> +static void nbd_start_replication(BlockDriverState *bs, COLOMode mode,
> + Error **errp)
> +{
> + BDRVNBDState *s = bs->opaque;
> +
> + /*
> + * TODO: support COLO_SECONDARY_MODE if we allow secondary
> + * QEMU becoming primary QEMU.
> + */
> + if (mode != COLO_MODE_PRIMARY) {
> + error_set(errp, QERR_INVALID_PARAMETER, "mode");
Please use error_setg. (Please grep the whole series :)
Fam
- Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description, (continued)
Re: [Qemu-devel] [RFC PATCH COLO v2 01/13] docs: block replication's description, Fam Zheng, 2015/03/26
[Qemu-devel] [RFC PATCH COLO v2 02/13] quorum: allow ignoring child errors, Wen Congyang, 2015/03/25
[Qemu-devel] [RFC PATCH COLO v2 03/13] NBD client: connect to nbd server later, Wen Congyang, 2015/03/25
[Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication, Wen Congyang, 2015/03/25
[Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication, Wen Congyang, 2015/03/25
[Qemu-devel] [RFC PATCH COLO v2 05/13] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/03/25