[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status
Date: Tue, 24 Mar 2015 09:53:47 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Dec 11, 2014 at 02:36:14PM +0100, Wolfgang Link wrote:
> this qmp command returns the current link state from the given nic
> this is impotent if the set_link failed or get an timeout.


I don't understand the rationale for this patch:

set_link does not fail or time out asynchronously, and the caller
immediately knows whether set_link succeeded or failed.  So I think this
command is not strictly necessary as implied by the commit description,
but it is useful if the QMP client wishes to query the current link

> +get_link_status
> +--------
> +
> +Get the link status of a network adapter.
> +
> +Arguments:
> +
> +- "name": network device name (json-string)
> +
> +Example:
> +
> +-> { "execute": "set_link", "arguments": { "name": "e1000.0" } }
> +<- { "return": {1} }

Please add a query-link-status command.  All QMP commands that fetch
data are called query-*.

Attachment: pgpcfGhimVd6L.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]