Re: [Qemu-devel] [PATCH v3] rcu tests: fix compilation on 32-bit ppc

[Andreas Färber]

Am 22.03.2015 um 09:26 schrieb Paolo Bonzini:
> 32-bit PPC cannot do atomic operations on long long.  Inside the loops,
> we are already using local counters that are summed at the end of
> the run---with some exceptions (rcu_stress_count for rcutorture,
> n_nodes for test-rcu-list): fix them to use the same technique.
> For test-rcu-list, remove the mostly unused member "val" from the
> list.  Then, use a mutex to protect the global counts.
> 
> Performance does not matter there because every thread will only enter
> the critical section once.
> 
> Remaining uses of atomic instructions are for ints or pointers.
> 
> Reported-by: Andreas Faerber <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  tests/rcutorture.c    | 20 ++++++++++++++++----
>  tests/test-rcu-list.c | 50 ++++++++++++++++++++++++++++----------------------
>  2 files changed, 44 insertions(+), 26 deletions(-)

Tested-by: Andreas Färber <address@hidden>

Passing these tests now, but running into unrelated qtest failures.

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)