[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property
Date: Mon, 23 Mar 2015 16:58:00 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 23/03/2015 16:01, Peter Crosthwaite wrote:
> Note that SD has a SPI mode, every SD card is in theory a valid SSI
> device. We could unify SD under SSI to achieve both QOMification and
> busification.

That wouldn't really be the way most SD cards work, anyway.  The
protocol doesn't do simultaneous bidirectional transfers like SSI does.

With your proposal the right way to invoke sdhci-pci would be "-device
sdhci-pci,id=sdhci -drive if=none,...,id=sd -device

Similarly, instantiating an SD card on an SSI bus would be "-device
ssi-sd,id=ssisd -drive if=none,...,id=sd -device sd,drive=sd,bus=ssisd.0".

> I would then expect the block setup of sd.c to be very similar to
> hw/block/m25p80.c (SPI flash).

Absolutely not, hw/block/m25p80.c has the same issue of doing
drive_get_next in the realize function.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]