[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 09/19] virito: introduce bus specific queue l
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH V4 09/19] virito: introduce bus specific queue limit |
Date: |
Fri, 20 Mar 2015 11:20:05 +0100 |
On Wed, 18 Mar 2015 17:34:59 +0800
Jason Wang <address@hidden> wrote:
Typo in subject: s/virito/virtio/
> This patch introduces a bus specific queue limitation. It will be
> useful for increasing the limit for one of the bus without disturbing
> other buses.
>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---
> hw/char/virtio-serial-bus.c | 2 +-
> hw/net/virtio-net.c | 4 ++--
> hw/s390x/s390-virtio-bus.c | 1 +
> hw/s390x/virtio-ccw.c | 1 +
> hw/scsi/virtio-scsi.c | 4 ++--
> hw/virtio/virtio-mmio.c | 1 +
> hw/virtio/virtio-pci.c | 1 +
> hw/virtio/virtio.c | 40 +++++++++++++++++++++++++---------------
> include/hw/virtio/virtio-bus.h | 1 +
> include/hw/virtio/virtio.h | 1 +
> 10 files changed, 36 insertions(+), 20 deletions(-)
> diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
> index 047c963..2b41e32 100644
> --- a/hw/s390x/s390-virtio-bus.c
> +++ b/hw/s390x/s390-virtio-bus.c
> @@ -715,6 +715,7 @@ static void virtio_s390_bus_class_init(ObjectClass
> *klass, void *data)
> bus_class->max_dev = 1;
> k->notify = virtio_s390_notify;
> k->get_features = virtio_s390_get_features;
> + k->queue_max = VIRTIO_PCI_QUEUE_MAX;
I'm wondering whether we should initialize queue_max to smth like
VIRTIO_QUEUE_MAX_DEFAULT (== 64) in virtio-bus.c instead and have the
individual classes override that value once they want to use a
different value?
But I'm fine with this patch as it stands as well.
> }
- [Qemu-devel] [PATCH V4 08/19] virtio-net: fix the upper bound when trying to delete queues, (continued)
- [Qemu-devel] [PATCH V4 08/19] virtio-net: fix the upper bound when trying to delete queues, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 07/19] virtio-net: validate backend queue numbers against bus limitation, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 10/19] virtio-ccw: introduce ccw specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 09/19] virito: introduce bus specific queue limit, Jason Wang, 2015/03/18
- Re: [Qemu-devel] [PATCH V4 09/19] virito: introduce bus specific queue limit,
Cornelia Huck <=
- [Qemu-devel] [PATCH V4 11/19] virtio-s390: switch to bus specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 13/19] virtio-pci: switch to use bus specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 12/19] virtio-mmio: switch to bus specific queue limit, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 14/19] virtio: introduce vector to virtqueues mapping, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 16/19] virtio-pci: speedup MSI-X masking and unmasking, Jason Wang, 2015/03/18
- [Qemu-devel] [PATCH V4 15/19] virtio: introduce virtio_queue_get_index(), Jason Wang, 2015/03/18