On Thu, Mar 19, 2015 at 01:19:23PM +0800, Jason Wang wrote:
On Wed, Mar 18, 2015 at 8:52 PM, Michael S. Tsirkin
<address@hidden> wrote:
>On Wed, Mar 18, 2015 at 05:35:08PM +0800, Jason Wang wrote:
>> This patch let msix_init_exclusive_bar() can accept bar_size
parameter
>> other than a hard-coded limit 4096. Then caller can specify a
bar_size
>> depends on msix entries and can use up to 2048 msix entries as
PCI
>> spec allows. To keep migration compatibility, 4096 is used for
all
>> callers and pba were start from half of bar size.
>> Cc: Keith Busch <address@hidden>
>> Cc: Kevin Wolf <address@hidden>
>> Cc: Stefan Hajnoczi <address@hidden>
>> Cc: Michael S. Tsirkin <address@hidden>
>> Signed-off-by: Jason Wang <address@hidden>
>
>Hmm this API looks strange. Caller will then have to have
>msi specific knowledge.
>Can't we keep the size iternal to msix.c?
Looks like we can, but still need an extra parameter e.g a boolean
compat_size to let msix_init_exclusive_bar() to use 4096 as bar
size.
Why not just figure the size out from # of vectors?