[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky err
Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class
Thu, 19 Mar 2015 08:22:06 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
On 03/19/2015 05:29 AM, Kevin Wolf wrote:
> Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben:
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit
>> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace
>> Signed-off-by: Markus Armbruster <address@hidden>
> Thanks, applied to the block branch.
> Eric, please speak up if libvirt needs the error code for any of these.
Libvirt is not using blockdev-backup yet, and so by implication does not
care about the error class.
Reviewed-by: Eric Blake <address@hidden>
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature