Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

[Michael S. Tsirkin]

On Thu, Mar 19, 2015 at 08:45:29AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > >   if yes we'll eventually want to take
> > > >   the header from there.
> > > 
> > > Yes, we can do that, for both linux input layer and virtio-input (once
> > > merged upstream) headers, then go build this on non-linux hosts too.
> > > 
> > > I'd suggest to do that as incremental patch, after guest driver merge.
> > 
> > Hmm but why? It's just code churn.
> 
> Adding not-yet upstream files to the list of headers to sync over from
> linux isn't sane IMHO.
> 
> cheers,
>   Gerd
> 

Of course it isn't. But you can sync it manually. Once it's upstream,
add it to list for automated sync.
Copy-pasting some defs from there in an unrelated header
seems worse.

-- 
MST