[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCH v4 1/6] acpi, mem-hotplug: Add acpi_memor
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RESEND PATCH v4 1/6] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus |
Date: |
Thu, 19 Mar 2015 06:59:25 +0100 |
On Thu, Mar 19, 2015 at 09:52:59AM +0800, Zhu Guihua wrote:
>
> On 03/16/2015 09:58 PM, Michael S. Tsirkin wrote:
> >On Mon, Mar 16, 2015 at 04:58:13PM +0800, Zhu Guihua wrote:
> >>From: Tang Chen <address@hidden>
> >>
> >>Add a new API named acpi_memory_slot_status() to obtain a single memory
> >>slot status. Doing this is because this procedure will be used by other
> >>functions in the next coming patches.
> >>
> >>Signed-off-by: Tang Chen <address@hidden>
> >>Signed-off-by: Zhu Guihua <address@hidden>
> >It's generally only OK to add API in a separate
> >patch from its use if the API is well documented.
> >There's 0 documentation here, so please just squash this
> >with the user so one can review without jumping
> >back and forth.
>
> The new API will be used in several places. If I squash this with the
> user, I think the patch will be too large.
>
> So I think it is better to add documentation here. what's your opinion?
>
> Thanks,
> Zhu
That's fine too.
- [Qemu-devel] [RESEND PATCH v4 0/6] QEMU memory hot unplug support, Zhu Guihua, 2015/03/16
- [Qemu-devel] [RESEND PATCH v4 2/6] acpi, mem-hotplug: Add unplug request cb for memory device, Zhu Guihua, 2015/03/16
- [Qemu-devel] [RESEND PATCH v4 3/6] pc-dimm: Add memory hot unplug request support for pc-dimm, Zhu Guihua, 2015/03/16
- [Qemu-devel] [RESEND PATCH v4 4/6] acpi, mem-hotplug: Add unplug cb for memory device, Zhu Guihua, 2015/03/16
- [Qemu-devel] [RESEND PATCH v4 5/6] pc-dimm: Add memory hot unplug support for pc-dimm, Zhu Guihua, 2015/03/16
- [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug, Zhu Guihua, 2015/03/16