[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging u

From: Gonglei
Subject: Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging uhci controller
Date: Wed, 18 Mar 2015 15:21:30 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015/3/18 15:02, Gerd Hoffmann wrote:
>   Hi,
>> -static void uhci_reset(void *opaque)
>> +static void uhci_reset(DeviceState *dev)
>>  {
>> -    UHCIState *s = opaque;
>> +    PCIDevice *d = PCI_DEVICE(dev);
>> +    UHCIState *s = DO_UPCAST(UHCIState, dev, d);
> Uh, oh, DO_UPCAST() is long deprecated.  There are other instances of
> this in the uhci emulation though, so we need a cleanup & qom-ify pass
> for the code anyway.  So I think it's ok for a bugfix patch.
Yes, I noticed that, but I haven't a good idea for qom-ifing uhci. :)
May we refer to the realization of ehci ?

> I'll queue it up (and the other two too of course).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]