[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/11] qmp: Add an implementation wrapper for qm
Re: [Qemu-devel] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup
Tue, 17 Mar 2015 14:15:51 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
On 03/17/2015 01:16 PM, John Snow wrote:
>> Other than that, I'm okay with a forward-declaration; if you want to
>> move it, but I'd be fine with moving the code, too.
>> With _drive_backup() being called do_drive_backup():
>> Reviewed-by: Max Reitz <address@hidden>
> Moving the code around might be better, it just makes for a much noisier
> patch. I made my decisions for v1 to keep code disturbed the least.
> Once more critiques roll in I will decide what to do.
I like avoiding forward declarations for non-recursive static functions
(aka topological sorting); but if you do code motion, do it in a
separate patch from the other changes.
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 01/11] qapi: Add transaction support to block-dirty-bitmap operations, John Snow, 2015/03/04
[Qemu-devel] [PATCH 08/11] iotests: add QMP event waiting queue, John Snow, 2015/03/04
[Qemu-devel] [PATCH 03/11] block: add transactional callbacks feature, John Snow, 2015/03/04