[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/7] qom: Implement qom-set HMP command
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL 4/7] qom: Implement qom-set HMP command |
Date: |
Tue, 17 Mar 2015 16:08:09 +0100 |
Re-implemented based on qmp_qom_set() to facilitate argument parsing.
Warn about ambiguous path arguments.
Reviewed-by: Gonglei <address@hidden>
Tested-by: Alistair Francis <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
hmp-commands.hx | 13 +++++++++++++
hmp.c | 21 +++++++++++++++++++++
hmp.h | 1 +
3 files changed, 35 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 527fa2d..d9f6c03 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1687,6 +1687,19 @@ Print QOM properties of object at location @var{path}
ETEXI
{
+ .name = "qom-set",
+ .args_type = "path:s,property:s,value:s",
+ .params = "path property value",
+ .help = "set QOM property",
+ .mhandler.cmd = hmp_qom_set,
+ },
+
+STEXI
address@hidden qom-set @var{path} @var{property} @var{value}
+Set QOM property @var{property} of object at location @var{path} to value
@var{value}
+ETEXI
+
+ {
.name = "info",
.args_type = "item:s?",
.params = "[subcommand]",
diff --git a/hmp.c b/hmp.c
index 92decae..ad1beba 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1892,3 +1892,24 @@ void hmp_qom_list(Monitor *mon, const QDict *qdict)
}
hmp_handle_error(mon, &err);
}
+
+void hmp_qom_set(Monitor *mon, const QDict *qdict)
+{
+ const char *path = qdict_get_str(qdict, "path");
+ const char *property = qdict_get_str(qdict, "property");
+ const char *value = qdict_get_str(qdict, "value");
+ Error *err = NULL;
+ bool ambiguous = false;
+ Object *obj;
+
+ obj = object_resolve_path(path, &ambiguous);
+ if (obj == NULL) {
+ error_set(&err, QERR_DEVICE_NOT_FOUND, path);
+ } else {
+ if (ambiguous) {
+ monitor_printf(mon, "Warning: Path '%s' is ambiguous\n", path);
+ }
+ object_property_parse(obj, value, property, &err);
+ }
+ hmp_handle_error(mon, &err);
+}
diff --git a/hmp.h b/hmp.h
index c5676e2..2b9308b 100644
--- a/hmp.h
+++ b/hmp.h
@@ -97,6 +97,7 @@ void hmp_object_del(Monitor *mon, const QDict *qdict);
void hmp_info_memdev(Monitor *mon, const QDict *qdict);
void hmp_info_memory_devices(Monitor *mon, const QDict *qdict);
void hmp_qom_list(Monitor *mon, const QDict *qdict);
+void hmp_qom_set(Monitor *mon, const QDict *qdict);
void object_add_completion(ReadLineState *rs, int nb_args, const char *str);
void object_del_completion(ReadLineState *rs, int nb_args, const char *str);
void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
--
2.1.4
- [Qemu-devel] [PULL 0/7] QOM devices patch queue 2015-03-17, Andreas Färber, 2015/03/17
- [Qemu-devel] [PULL 5/7] qom: Implement info qom-tree HMP command, Andreas Färber, 2015/03/17
- [Qemu-devel] [PULL 3/7] qom: Implement qom-list HMP command, Andreas Färber, 2015/03/17
- [Qemu-devel] [PULL 2/7] scripts: Add qom-tree script, Andreas Färber, 2015/03/17
- [Qemu-devel] [PULL 4/7] qom: Implement qom-set HMP command,
Andreas Färber <=
- [Qemu-devel] [PULL 7/7] qdev: Move owner-less IRQs to /machine/unattached, Andreas Färber, 2015/03/17
- [Qemu-devel] [PULL 1/7] cadence_uart: Convert to QOM realize(), Andreas Färber, 2015/03/17
- [Qemu-devel] [PULL 6/7] memory: Move owner-less MemoryRegions to /machine/unattached, Andreas Färber, 2015/03/17
- Re: [Qemu-devel] [PULL 0/7] QOM devices patch queue 2015-03-17, Peter Maydell, 2015/03/17