[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 20/25] block/nbd: Comment on discard/flush silen

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 20/25] block/nbd: Comment on discard/flush silently failing
Date: Mon, 16 Mar 2015 10:52:11 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 2015-03-16 at 10:51, Paolo Bonzini wrote:

On 16/03/2015 15:49, Max Reitz wrote:
Right, but a better model than block.c should be for example
block/raw-posix.c, which returns ENOTSUP (I checked now...).
Maybe we should catch ENOTSUP in bdrv_co_discard() and override it?
That's what it does:

         if (ret && ret != -ENOTSUP) {
             return ret;

Oops, thanks for telling me. Good, then I'll do that, thanks.


Returning 0 for NBD's flush_to_disk, by the way, is okay.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]