[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG |
Date: |
Mon, 16 Mar 2015 13:06:33 +0000 |
Daniel P. Berrange <address@hidden> writes:
> Handling of VNC audio messages results in printfs to the console.
> This is of no use to anyone in production, so should be using the
> normal VNC_DEBUG macro instead.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> ui/vnc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 6f9b718..80dc63b 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2400,34 +2400,34 @@ static int protocol_client_msg(VncState *vs, uint8_t
> *data, size_t len)
> case 4: vs->as.fmt = AUD_FMT_U32; break;
> case 5: vs->as.fmt = AUD_FMT_S32; break;
> default:
> - printf("Invalid audio format %d\n", read_u8(data, 4));
> + VNC_DEBUG("Invalid audio format %d\n", read_u8(data, 4));
> vnc_client_error(vs);
> break;
> }
> vs->as.nchannels = read_u8(data, 5);
> if (vs->as.nchannels != 1 && vs->as.nchannels != 2) {
> - printf("Invalid audio channel coount %d\n",
> - read_u8(data, 5));
> + VNC_DEBUG("Invalid audio channel coount %d\n",
> + read_u8(data, 5));
> vnc_client_error(vs);
> break;
> }
> vs->as.freq = read_u32(data, 6);
> break;
> default:
> - printf ("Invalid audio message %d\n", read_u8(data, 4));
> + VNC_DEBUG("Invalid audio message %d\n", read_u8(data, 4));
> vnc_client_error(vs);
> break;
> }
> break;
>
> default:
> - printf("Msg: %d\n", read_u16(data, 0));
> + VNC_DEBUG("Msg: %d\n", read_u16(data, 0));
> vnc_client_error(vs);
> break;
> }
> break;
> default:
> - printf("Msg: %d\n", data[0]);
> + VNC_DEBUG("Msg: %d\n", data[0]);
> vnc_client_error(vs);
> break;
> }
--
Alex Bennée
[Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG, Daniel P. Berrange, 2015/03/16
- Re: [Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG,
Alex Bennée <=
[Qemu-devel] [PATCH 1/3] ui: remove unused 'wiremode' variable in VncState struct, Daniel P. Berrange, 2015/03/16