[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error clas
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class |
|
Date: |
Fri, 13 Mar 2015 13:15:22 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/13/2015 11:48 AM, Markus Armbruster wrote:
> Markus Armbruster <address@hidden> writes:
>
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f
>> added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it.
"always" is a strong word; there are cases where alternate error classes
are useful. But I agree that this does not seem to be one of those
cases. Therefore:
>
> Signed-off-by: Markus Armbruster <address@hidden>
>
>> ui/vnc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature