[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd |
Date: |
Fri, 13 Mar 2015 13:53:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 13/03/2015 06:17, Shannon Zhao wrote:
>> > - monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : false,
>> > - fd_opaque, NULL);
>> > + fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true
>> > : false,
>> > + fd_opaque, NULL);
>> > + g_free(fdinfo);
>> >
>> > return 0;
>> > }
>> >
> Hi Paolo,
>
> Not about the resource leak, but I think we should check fdinfo == NULL and
> return -1.
> Then when error occurs, qemu will exit. Besides we should pass a meaningful
> errp not NULL.
> So qemu can report the error reason. Right?
It cannot fail here, so another possibility could be to pass &error_abort.
Paolo
- [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd, Paolo Bonzini, 2015/03/12
- Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd, Eric Blake, 2015/03/12
- Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd, Fam Zheng, 2015/03/12
- Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd, Patchew Tool, 2015/03/12
- Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd, Shannon Zhao, 2015/03/13
- Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd, Michael Tokarev, 2015/03/19