[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fsdev/virtfs-proxy-helper: Fix possible overflo
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] fsdev/virtfs-proxy-helper: Fix possible overflow |
|
Date: |
Fri, 13 Mar 2015 13:51:01 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 13/03/2015 12:09, Shannon Zhao wrote:
> + g_assert(strlen(path) < sizeof(proxy.sun_path));
> sock = socket(AF_UNIX, SOCK_STREAM, 0);
> if (sock < 0) {
> do_perror("socket");
> @@ -748,7 +749,7 @@ static int proxy_socket(const char *path, uid_t uid,
> gid_t gid)
> umask(7);
>
> proxy.sun_family = AF_UNIX;
> - strcpy(proxy.sun_path, path);
> + strncpy(proxy.sun_path, path, sizeof(proxy.sun_path));
> if (bind(sock, (struct sockaddr *)&proxy,
Same as the other patch.
Paolo