[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/7] vnc: fix segmentation fault when invalid vnc par
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 7/7] vnc: fix segmentation fault when invalid vnc parameters are specified |
Date: |
Thu, 12 Mar 2015 10:00:25 +0100 |
From: Gonglei <address@hidden>
Reproducer:
#./qemu-system-x86_64 -vnc :0,ip
qemu-system-x86_64: -vnc :1,ip: Invalid parameter 'ip'
Segmentation fault (core dumped)
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 1e95445..6f9b718 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3703,8 +3703,13 @@ QemuOpts *vnc_parse_func(const char *str)
{
QemuOptsList *olist = qemu_find_opts("vnc");
QemuOpts *opts = qemu_opts_parse(olist, str, 1);
- const char *id = qemu_opts_id(opts);
+ const char *id;
+ if (!opts) {
+ return NULL;
+ }
+
+ id = qemu_opts_id(opts);
if (!id) {
/* auto-assign id if not present */
vnc_auto_assign_id(olist, opts);
--
1.8.3.1
- [Qemu-devel] [PULL 0/7] vnc patch queue., Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 2/7] vnc: remove dead code, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 6/7] vnc: avoid possible file handler leak, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 7/7] vnc: fix segmentation fault when invalid vnc parameters are specified,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 5/7] ui/console: fix OVERFLOW_BEFORE_WIDEN, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 3/7] vnc: switch to inet_listen_opts, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 4/7] ui: fix regression in x509verify parameter for VNC server, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 1/7] vnc: drop display+ws_display from VncDisplay, Gerd Hoffmann, 2015/03/12
- Re: [Qemu-devel] [PULL 0/7] vnc patch queue., Peter Maydell, 2015/03/12