[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/7] vnc: avoid possible file handler leak
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 6/7] vnc: avoid possible file handler leak |
Date: |
Thu, 12 Mar 2015 10:00:24 +0100 |
From: Gonglei <address@hidden>
vs->lsock may equal to 0, modify the check condition,
avoid possible vs->lsock leak.
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index b514777..1e95445 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3644,7 +3644,7 @@ void vnc_display_open(const char *id, Error **errp)
if (vs->ws_enabled) {
vs->lwebsock = inet_listen_opts(wsopts, 0, errp);
if (vs->lwebsock < 0) {
- if (vs->lsock) {
+ if (vs->lsock != -1) {
close(vs->lsock);
vs->lsock = -1;
}
--
1.8.3.1
- [Qemu-devel] [PULL 0/7] vnc patch queue., Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 2/7] vnc: remove dead code, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 6/7] vnc: avoid possible file handler leak,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 7/7] vnc: fix segmentation fault when invalid vnc parameters are specified, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 5/7] ui/console: fix OVERFLOW_BEFORE_WIDEN, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 3/7] vnc: switch to inet_listen_opts, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 4/7] ui: fix regression in x509verify parameter for VNC server, Gerd Hoffmann, 2015/03/12
- [Qemu-devel] [PULL 1/7] vnc: drop display+ws_display from VncDisplay, Gerd Hoffmann, 2015/03/12
- Re: [Qemu-devel] [PULL 0/7] vnc patch queue., Peter Maydell, 2015/03/12