[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v2][PATCH 1/2] libxl: introduce libxl__is_igd_vga_pass
From: |
Ian Campbell |
Subject: |
Re: [Qemu-devel] [v2][PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru |
Date: |
Wed, 11 Mar 2015 11:26:28 +0000 |
On Tue, 2015-03-10 at 17:42 +0800, Tiejun Chen wrote:
> While working with qemu, IGD is a specific device in the case of pass through
> so we need to identify that to handle more later. Here we define a table to
> record all IGD types currently we can support. Also we need to introduce two
> helper functions to get vendor and device ids to lookup that table.
>
> Signed-off-by: Tiejun Chen <address@hidden>
Acked-by: Ian Campbell <address@hidden>
> + FILE *f = fopen(pci_device_vendor_path, "r");
I was about to ask if we should use the carefd construct here, but
libxl_pci.c is full of fopen, so this isn't making things any worse at
least.