[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1

From: Aneesh Kumar K.V
Subject: Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1
Date: Tue, 10 Mar 2015 23:01:40 +0530
User-agent: Notmuch/0.19+30~gd241a48 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)

Michael Tokarev <address@hidden> writes:

> 08.03.2015 19:39, Aneesh Kumar K.V wrote:
>> Michael Tokarev <address@hidden> writes:
>>> This simplifies code in v9fs_request() a bit by replacing several
>>> ifs with a common variable check and rearranging error/cleanup
>>> code a bit.
>> Is this -V2 of
>> http://mid.gmane.org/address@hidden
> No, this one (simplify v9fs_reqeust(), P1) was a first version.
> The above URL points to the v2, a second version.

Please post an update patch series with the variable rename and the v9fs
simplification as two different patches.

>> I am slightly confused with the patch series. It does split the patch as
>> I wanted, but i am not sure which one is the latest, so that i can start
>> applying them.
> That URL points to last.  I merged several small patches into larger ones.
> Initially I thought I just plug a small resource leak so the patch will
> be small.  But the more I understood the code, the bigger the changes
> were becoming.  So at some point it become unreasonable to keep small
> changes since they're related to bigger changes and since bigger changes
> touches the same code anyway.

Please keep the patches smaller. If needed i can fold them up when
merging the changes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]