[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] configure: handle clang -nopie argument war

From: John Snow
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: handle clang -nopie argument warning
Date: Tue, 10 Mar 2015 13:10:12 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 03/10/2015 08:23 AM, Stefan Hajnoczi wrote:
gcc 4.9.2 treats -nopie as an error:

   cc: error: unrecognized command line option ‘-nopie’

clang 3.5.0 treats -nopie as a warning:

   clang: warning: argument unused during compilation: '-nopie'

The causes ./configure to fail with clang:

   ERROR: configure test passed without -Werror but failed with -Werror.

Make the -nopie test use -Werror so that compile_prog works for both gcc
and clang.

Signed-off-by: Stefan Hajnoczi <address@hidden>
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 7ba4bcb..4f9f689 100755
--- a/configure
+++ b/configure
@@ -1589,7 +1589,7 @@ EOF

-  if compile_prog "-fno-pie" "-nopie"; then
+  if compile_prog "-Werror -fno-pie" "-nopie"; then

Oh, clang doesn't support -nopie but doesn't fail, so we have to force it to in order to get proper configuration.

Makes sense.

Reviewed-by: John Snow <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]