[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Revert "timer: replace time() with QEMU_CLOCK_H

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] Revert "timer: replace time() with QEMU_CLOCK_HOST"
Date: Tue, 10 Mar 2015 12:05:05 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 10/03/2015 03:43, Alexey Kardashevskiy wrote:
> This reverts commit 2ed1ebcf65edf6757d8904000889ce52cc0a9d1b
> as it breaks compile when configured with --enable-profiler:
> /home/alexey/p/qemu/vl.c:710:15: error: 'qemu_time' redeclared as different 
> kind of symbol
>  static time_t qemu_time(void)
>                ^
> In file included from /home/alexey/p/qemu/include/block/aio.h:23:0,
>                  from /home/alexey/p/qemu/include/hw/hw.h:13,
>                  from /home/alexey/p/qemu/vl.c:62:
> /home/alexey/p/qemu/include/qemu/timer.h:1005:16: note: previous declaration 
> of 'qemu_time' was here
>  extern int64_t qemu_time, qemu_time_start;
>                 ^
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
> I could rename qemu_time() but could not think of any nice and simple name
> instead so here is revert :)

ENABLE_PROFILER is a bit broken in many ways:

1) half of it only works for TCG, but doesn't say this anywhere.

2) the division by get_ticks_per_sec() doesn't work since the unit of
measurement is clock cycles rather than nanoseconds.  (Broken since 2006).

3) you really can get the same information from "top" now that we have
VCPU threads.

4) It declares non-existing extern variables qemu_time_start and
tlb_flush_time, the latter of which has never existed _at all_.

But let's fix it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]