[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] disas/cris: Fix warning caused by missing 'stat
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH] disas/cris: Fix warning caused by missing 'static' attribute |
Date: |
Tue, 10 Mar 2015 08:09:29 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 |
01.03.2015 16:07, Stefan Weil wrote:
> Warning from the Sparse static analysis tool:
>
> disas/cris.c:1218:26: warning:
> symbol 'cris_cond15s' was not declared. Should it be static?
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> disas/cris.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disas/cris.c b/disas/cris.c
> index 9dfb4e3..a034dba 100644
> --- a/disas/cris.c
> +++ b/disas/cris.c
> @@ -1215,7 +1215,7 @@ cris_cc_strings[] =
> };
>
> /* Different names and semantics for condition 1111 (0xf). */
> -const struct cris_cond15 cris_cond15s[] =
> +static const struct cris_cond15 cris_cond15s[] =
This is the same patch you sent 07-feb, with Message-Id:
<address@hidden>, and
the same patch which makes at least clang unhappy:
disas/cris.c:1218:33: error:
unused variable 'cris_cond15s' [-Werror,-Wunused-const-variable]
static const struct cris_cond15 cris_cond15s[] =
^
1 error generated.
I'll drop this patch and remove the unused variable
instead.
Thanks,
/mjt