[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING

From: Xiaodong Gong
Subject: Re: [Qemu-devel] [PATCH v10] Support vhd type VHD_DIFFERENCING
Date: Sun, 8 Mar 2015 09:53:31 +0800

2015年3月5日 06:15于 "Philipp Hahn" <address@hidden>写道:
> Hi,
> On 04.03.2015 15:18, Xiaodong Gong wrote:
> > @@ -157,6 +178,224 @@ static int vpc_probe(const uint8_t *buf, int buf_size, const char *filename)
> ..
> > +static int vpc_decode_maxc_loc(BlockDriverState *bs, uint32_t data_length)
> ...
> > +    cd = g_iconv_open("ASCII", "UTF8");
> ...
> > +static int vpc_decode_w2u_loc(BlockDriverState *bs, uint32_t data_length)
> ...
> > +    cd = g_iconv_open("ASCII", "UTF-16LE");
> Please correct me if my understanding is wrong, but a hard-coded "ASCII"
> is AFAIK wrong, as it only contains the 7-bit characters.
> For the Linux kernel the file name is just a string of bytes, but when
> it gets displayed to the user, the bytes are converted to characters.
> The conversion depends on the locale used, which now-adays is most often
> UTF-8 (LANG=de_DE.UTF-8, or more specifically LC_CTYPE), but some years
> back it was ISO-8859-1 (or what-ever).
> So if I create a backing file with some non-ASCII umlauts, the
> conversion will break, as ß = &szlig; = \uc39f = ISO-8859-1(0xdf)

the encoding type of parent location is must be utf 8,utf16e,according to the draft

ascii is the encoding type to store the string of parent location in memery and to use fopen()

ascii need to translate to other encoding type accirding to LANG when to show the infomation of the vhd file using the qemu-info and so on

> AFAIK using nl_langinfo(CODESET) would return the codeset previously set
> by setlocale(LC_ALL, ""), which any main program would need to do.
> Am I missing something?
> Sincerely
> Philipp

reply via email to

[Prev in Thread] Current Thread [Next in Thread]