qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] block/null: Latency simulation by adding new


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2] block/null: Latency simulation by adding new option "latency_ns"
Date: Fri, 06 Mar 2015 10:14:22 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/04/2015 06:32 PM, Fam Zheng wrote:
> Aio context switch should just work because the requests will be
> drained, so the scheduled timer(s) on the old context will be freed.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> 
> ---
> v2: Check for negative value; add sleep in null-co://. [Kevin]
> ---
>  block/null.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 50 insertions(+), 5 deletions(-)

Is it possible to pass this new parameter via QMP?  If so, shouldn't the
.json file also document it?  And if so, should it be named with '-'
instead of '_' for use from QMP?


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]