[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to user
Date: Fri, 06 Mar 2015 09:24:32 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/04/2015 07:09 AM, zhanghailiang wrote:
> 'cancelling' status is introduced by commit 51cf4c1a, which is mainly avoid

s/is introduced/was introduced/
s/which is mainly avoid/mainly to avoid a/

> possible starting a new migration process while the previous one still exist.

s/starting a new/start of a new/

> But we don't expose this status to user, instead by return a 'active' state.

s/by return a/we returned the/

> Here, we expose it to the user (such as libvirt), 'cancelling' status only
> occurs for a short window before the migration aborts, so for users,
> if they cancell a migration process, it will observe 'cancelling' status


> occasionally.

Testing revealed that with older libvirt (anything 1.2.13 or less) will
print an odd error message if the state is seen, but that the migration
is still properly cancelled. Newer libvirt will be patched to recognize
the new state without the odd error message.

> Signed-off-by: zhanghailiang <address@hidden>
> Cc: address@hidden
> ---
>  migration/migration.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

With the grammar in the commit message fixed,
Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]