Re: [Qemu-devel] [PATCH v4 01/10] cpu/apic: drop icc bus/bridge/

[Eduardo Habkost]

On Fri, Feb 13, 2015 at 06:25:24PM +0800, Zhu Guihua wrote:
> From: Chen Fan <address@hidden>
> 
> ICC bus was invented only to provide hotplug capability to
> CPU and APIC because at the time being hotplug was available only for
> BUS attached devices.
> 
> Now this patch is to drop ICC bus impl, and switch to bus-less
> CPU+APIC hotplug, handling them in the same manner as pc-dimm.
> 
> Signed-off-by: Chen Fan <address@hidden>
> Signed-off-by: Zhu Guihua <address@hidden>
> ---
>  hw/i386/kvm/apic.c              | 10 ++++++++--
>  hw/i386/pc.c                    | 21 +++++----------------
>  hw/i386/pc_piix.c               |  9 +--------
>  hw/i386/pc_q35.c                |  9 +--------
>  hw/intc/apic.c                  | 16 +++++++++++-----
>  hw/intc/apic_common.c           | 14 +++++++++-----
>  include/hw/i386/apic_internal.h |  6 ++----
>  include/hw/i386/pc.h            |  3 ++-
>  target-i386/cpu.c               | 19 +++----------------
>  target-i386/cpu.h               |  3 +--
>  10 files changed, 43 insertions(+), 67 deletions(-)

What about hw/i386/xen/xen_apic.c:xen_apic_realize()?

  $ make
    CC    x86_64-softmmu/hw/i386/xen/xen_apic.o
  /home/ehabkost/rh/proj/virt/qemu/hw/i386/xen/xen_apic.c: In function 
‘xen_apic_realize’:
  /home/ehabkost/rh/proj/virt/qemu/hw/i386/xen/xen_apic.c:44:29: error: 
‘APICCommonState’ has no member named ‘io_memory’
       memory_region_init_io(&s->io_memory, OBJECT(s), &xen_apic_io_ops, s,
                               ^
  /home/ehabkost/rh/proj/virt/qemu/rules.mak:57: recipe for target 
'hw/i386/xen/xen_apic.o' failed
  make[1]: *** [hw/i386/xen/xen_apic.o] Error 1
  Makefile:169: recipe for target 'subdir-x86_64-softmmu' failed
  make: *** [subdir-x86_64-softmmu] Error 2

-- 
Eduardo