Re: [Qemu-devel] [PATCH v4 2/2] spapr: override default ram size to 1GB

[Alexander Graf]

On 05.03.15 12:56, Nikunj A Dadhania wrote:
> Signed-off-by: Nikunj A Dadhania <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
> ---
>  hw/ppc/spapr.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 23cde20..c71ee4b 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -96,6 +96,7 @@ typedef struct sPAPRMachineState sPAPRMachineState;
>  #define SPAPR_MACHINE(obj) \
>      OBJECT_CHECK(sPAPRMachineState, (obj), TYPE_SPAPR_MACHINE)
>  
> +#define SPAPR_DEFAULT_RAM_SIZE   (1UL << 30)

UL is almost always wrong on QEMU land. Please use ULL.

Also I find 1 << 30 pretty hard to read. Can't we just define simple
KB/MB/GB/TB helpers somewhere in a header file and just fold this is
below as ..

>  /**
>   * sPAPRMachineState:
>   */
> @@ -1738,6 +1739,7 @@ static void spapr_machine_class_init(ObjectClass *oc, 
> void *data)
>      mc->max_cpus = MAX_CPUS;
>      mc->no_parallel = 1;
>      mc->default_boot_order = NULL;
> +    mc->default_ram_size = SPAPR_DEFAULT_RAM_SIZE;

mc->default_ram_size = 1 * GB;


Alex

>      mc->kvm_type = spapr_kvm_type;
>      mc->has_dynamic_sysbus = true;
>  
>