Re: [Qemu-devel] [PATCH] block/raw-posix: fix launching with failed disks

[Kevin Wolf]

Am 04.03.2015 um 23:48 hat Stefan Hajnoczi geschrieben:
> Since commit c25f53b06eba1575d5d0e92a0132455c97825b83 ("raw: Probe
> required direct I/O alignment") QEMU has failed to launch if image files
> produce I/O errors.
> 
> Previously, QEMU would launch successfully and the guest would see the
> errors when attempting I/O.
> 
> This is a regression and may prevent multipath I/O inside the guest,
> where QEMU must launch and let the guest figure out by itself which
> disks are online.
> 
> Tweak the alignment probing code in raw-posix.c to explicitly look for
> EINVAL on Linux instead of bailing.  The kernel refuses misaligned
> requests with this error code and other error codes can be ignored.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>

This seems to conflict with the geometry series. Please rebase on the
current block branch.

Also, I would be surprised if this had been working by design. It's
probably more by chance. If we want to make this a supported case, we
need to add a qemu-iotests case, as this seems to be easy to break
accidentally.

Kevin